replace ws4sql with new node sqlite module#36
Merged
Merged
Conversation
blaix
commented
May 15, 2026
robinheghan
approved these changes
May 15, 2026
| , { statement = "PRAGMA busy_timeout = 5000" | ||
| , parameters = [] | ||
| } | ||
| , { statement = "PRAGMA busy_timeout = 5000" |
Member
There was a problem hiding this comment.
This is defined by Sqlite.Options
| [ { statement = "PRAGMA foreign_keys = ON" | ||
| , parameters = [] | ||
| } | ||
| [ { statement = "PRAGMA foreign_keys = ON" |
Member
There was a problem hiding this comment.
This is defined by Sqlite.Options
Member
|
Looks good. You might want to remove two pragma's from the
Don't really have a good way of handling it until we cut a new |
these are already set by Sqlite.defaultOptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test runs are going to fail due to local node dependency. What's the best way to handle that?