Only rename identifiers that are textually equal#491
Draft
sorawee wants to merge 1 commit intogreghendershott:masterfrom
Draft
Only rename identifiers that are textually equal#491sorawee wants to merge 1 commit intogreghendershott:masterfrom
sorawee wants to merge 1 commit intogreghendershott:masterfrom
Conversation
It is possible to have an arrow between two identifiers that are not textually equivalent (definitely possible in DrRacket, and theoretically possible in Racket Mode). In the above event, renaming one identifier should not change the other. See also racket/drracket#415 for a similar fix in DrRacket, and racket/racket#3391 which would start to make Racket Mode behave incorrectly. In particular, with the above PR, renaming the identifier `a` in the following program should not rename `all-defined-out` as well. #lang racket (provide (all-defined-out)) (define a 1)
Contributor
Author
|
Note that with the above mentioned PR, attempting to run will offer users to rename a random defined identifier (it's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to have an arrow between two identifiers that are not
textually equivalent (definitely possible in DrRacket, and theoretically
possible in Racket Mode).
In the above event, renaming one identifier should not change the other.
See also racket/drracket#415 for a similar fix in DrRacket, and
racket/racket#3391 which would start to make Racket Mode behave
incorrectly. In particular, with the above PR, renaming
the identifier
ain the following program should not renameall-defined-outas well.