runtime: Bump wasmtime from 38.0.4 to 44.0.1#6577
Draft
incrypto32 wants to merge 3 commits into
Draft
Conversation
In wasmtime 42 `wasmtime::Error` was split from `anyhow::Error` and `Config::async_support` became a no-op. Convert at the wasmtime boundary so the rest of the runtime keeps using anyhow internally.
incrypto32
force-pushed
the
incrypto32/bump-wasmtime-44
branch
from
021581d to
51fa498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps wasmtime from 38.0.4 to 44.0.1.
The only API change across these releases that affects graph-node is from wasmtime 42:
wasmtime::Erroris no longer a re-export ofanyhow::Error, andConfig::async_supportis now a no-op. Fixes are localized to the runtime crate and convert at the wasmtime boundary.runtime/wasm/src/module/instance.rs:.map_err(anyhow::Error::from)at wasmtime call boundaries;wasmtime::Error::msg/wasmtime::Error::from_anyhowfor errors going into wasmtime.runtime/wasm/src/module/into_wasm_ret.rs: map anyhow→wasmtime viafrom_anyhowin theWasmRetimpl.runtime/wasm/src/module/mod.rs:trap.into()beforehost_export_error_from_trap.runtime/test/src/test.rs: same boundary conversion.runtime/wasm/src/mapping.rs: drop deprecatedconfig.async_support(true).Verified: `cargo check --workspace [--tests | --release]`, `just lint`. Unit tests / runner tests not yet run.
Closes #6549.
Closes #6506.
Closes #6513.
Closes #6338.