Fix documentation related to setInputFiles function#2205
Open
JunNishimura wants to merge 11 commits into
Open
Conversation
16 tasks
codebien
requested changes
Apr 1, 2026
codebien
left a comment
Contributor
There was a problem hiding this comment.
Hey @JunNishimura, can you sign the CLA, please? This is a requires step to merge this pull request.
Author
|
Hi, I signed the CLA. I would appreciate it if you review again. Thanks! |
codebien
approved these changes
Apr 13, 2026
oleiade
approved these changes
Apr 24, 2026
oleiade
left a comment
Contributor
There was a problem hiding this comment.
LGTM — documentation fix.
Contributor
|
I'm confused why the code examples are failing when they were not before? Any idea @heitortsergent ? |
Collaborator
|
@oleiade I'm confused as well... I don't see any regressions, besides removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
grafana/k6#4655
Regarding the issues discussed above, I have made corrections to the type definitions in the following pull request.
grafana/k6-DefinitelyTyped#115
Accordingly, the documentation was revised.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)
grafana/k6#4655
grafana/k6-DefinitelyTyped#115