fix(junit): Correctly identify panicking test in JUnit report#492
Open
vtsachev wants to merge 1 commit into
Open
fix(junit): Correctly identify panicking test in JUnit report#492vtsachev wants to merge 1 commit into
vtsachev wants to merge 1 commit into
Conversation
Member
|
Thanks for the PR! Since all the tests in a package run in the same process, I don't think it's safe to assume anything about which test caused the panic. From what I remember the Is the current behaviour causing problems? Do you see panics that often? Maybe there's a way the source of the panics can be fixed so that tests fail instead of panic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a test panics, the JUnit XML report previously marked all tests in the package as failed. This change introduces tracking for the specific test ID that first emits panic output. The JUnit reporter now uses this ID to mark the panicking test with instead of the generic "Failed", while allowing other tests in the package to retain their correct status. This addresses the issue where a single panic would incorrectly attribute failure to the entire package in the report.