srpm: set rpmpack SourceRPM metadata flag#1081
Open
alexma233 wants to merge 1 commit into
Open
Conversation
When building source RPMs (formatSRPM), set the new rpmpack RPMMetaData.SourceRPM flag. This instructs rpmpack to skip the SOURCERPM (RPMTAG_SOURCERPM, 1044) tag, which must not be present in source RPMs. Depends on google/rpmpack#105. Replace directive will be removed once a new rpmpack release is available.
pull-request-size
Bot
added
the
size/XS
Member
|
Good catch! Thank you! Let's see if rpmpack merges it soon 🙏🏻 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1081 +/- ##
==========================================
+ Coverage 73.94% 73.96% +0.01%
==========================================
Files 22 22
Lines 2756 2758 +2
==========================================
+ Hits 2038 2040 +2
Misses 494 494
Partials 224 224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building source RPMs, the
SOURCERPM(RPMTAG_SOURCERPM, 1044) tag must not be present. RPM utilities treat its presence as indicating a binary (non-source) RPM. This causes build services like Fedora COPR to reject source RPMs generated by thesrpmpackager.The upstream rpmpack (google/rpmpack#105) adds a
SourceRPMfield toRPMMetaDatathat controls whetherSOURCERPMis written. This PR:meta.SourceRPM = truewhen the packager format issrpmreplacedirective pointing to the rpmpack fork with the new fieldDependency
Depends on google/rpmpack#105 being merged and released.
The
replacedirective ingo.modshould be removed and the rpmpack dependency bumped once a new release is available.Verification
go test ./rpm/...— 73 tests pass, includingTestSRPMSOURCERPMtag header