fix: include RPM doc/licence/readme files in non-RPM packages#1072
Open
Yanhu007 wants to merge 1 commit into
Open
fix: include RPM doc/licence/readme files in non-RPM packages#1072Yanhu007 wants to merge 1 commit into
Yanhu007 wants to merge 1 commit into
Conversation
RPM-specific file types (doc, licence, license, readme) were excluded from deb and apk packages by isRelevantForPackager, contradicting the documentation which states they should be treated as normal files by other packagers. Only TypeRPMGhost is excluded from non-RPM packagers, since ghost files have no actual content. Document types are now included as normal files per the documented behavior. Fixes goreleaser#1037
pull-request-size
Bot
added
the
size/XS
Member
|
this have tests guarding it - i think it may be that we need to update the docs instead 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Problem
Files with
type: doc,type: licence,type: license, ortype: readmeare completely excluded from deb and apk packages. The documentation states these RPM-specific types should be "ignored" (treated as normal files) by other packagers.isRelevantForPackagerreturnsfalsefor all these types when the packager is not "rpm", causing them to be filtered out entirely.Fix
Only exclude
TypeRPMGhostfrom non-RPM packagers (ghost files have no actual content, so exclusion makes sense). Doc/licence/license/readme types are no longer excluded, allowing them to be treated as normal files per the documentation.This matches the documented behavior: