feat: add support for signing archlinux packages#1065
Open
flecno wants to merge 2 commits into
Open
Conversation
pull-request-size
Bot
added
the
size/L
flecno
commented
Apr 3, 2026
flecno
force-pushed
the
sign-archlinux-packages
branch
2 times, most recently
from
b1a4386 to
2cebadb
Compare
Author
|
@Elara6331 Do you want to take a look at this? |
Author
|
@caarlos0 Is there any chance to get this reviewed and merged? It's a very straight forward change |
caarlos0
reviewed
May 1, 2026
caarlos0
left a comment
caarlos0
left a comment
Member
There was a problem hiding this comment.
looking good overall, a couple of comments though.
thanks for the PR 🙏🏻
| key, err := readSigningKey(keyFile, passphrase) | ||
| sig, err := PGPArmoredDetachSignWithKeyID(bytes.NewReader(data), keyFile, passphrase, hexKeyID) | ||
| if err != nil { | ||
| return nil, &nfpm.ErrSigningFailure{Err: err} |
Member
There was a problem hiding this comment.
changing the error types returned is a breaking change. I don't think its really necessary...
Author
There was a problem hiding this comment.
I didn't change the error type here. This is the helper function used as RPM signer that wraps the error. Maybe we should extract it to the RPM module?
| DefaultHash: crypto.SHA256, | ||
| }, | ||
| ); err != nil { | ||
| return nil, &nfpm.ErrSigningFailure{Err: err} |
Author
|
Thanks! I'll go over it in the next few days |
flecno
force-pushed
the
sign-archlinux-packages
branch
2 times, most recently
from
3b0eeb6 to
62030db
Compare
Archlinux packages can now be signed with a detached PGP signature, producing a binary .sig file alongside the package — matching the format expected by pacman-key --verify. The signing reads back the finalized .pkg.tar.zst from disk via info.Target to avoid buffering the entire package in memory. The passphrase is taken from $NFPM_ARCHLINUX_PASSPHRASE with a fallback to $NFPM_PASSPHRASE, consistent with deb/rpm/apk. Also adds sign.PGPDetachedSignWithKeyID, a streaming variant of PGPSignerWithKeyID that accepts an io.Reader instead of []byte. See goreleaser#628
flecno
force-pushed
the
sign-archlinux-packages
branch
from
62030db to
4494ec6
Compare
Author
|
@caarlos0 I rebased the branch, fixed your comments and the lint errors and added an acceptance test for signed Arch Linux packages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archlinux packages can now be signed with a detached PGP signature, producing a binary .sig file alongside the package — matching the format expected by pacman-key --verify.
The signing reads back the finalized .pkg.tar.zst from disk via info.Target to avoid buffering the entire package in memory. The passphrase is taken from $NFPM_ARCHLINUX_PASSPHRASE with a fallback to $NFPM_PASSPHRASE, consistent with deb/rpm/apk.
Also adds sign.PGPDetachedSignWithKeyID, a streaming variant of PGPSignerWithKeyID that accepts an io.Reader instead of []byte.
See #628