Skip to content

Fix empty public.postscriptNames dict incorrectly triggering uniXXXX derivation #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthrotype merged 1 commit into from
May 14, 2026
+7 −1
Merged

Fix empty public.postscriptNames dict incorrectly triggering uniXXXX derivation #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/ufo2ft/postProcessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def process_glyph_names(self, useProductionNames=None):
useProductionNames = self.ufo.lib.get(
USE_PRODUCTION_NAMES,
not self.ufo.lib.get(GLYPHS_DONT_USE_PRODUCTION_NAMES)
and self._postscriptNames is not None,
and self._postscriptNames,
)
else:
keepGlyphNames = True
Expand Down
6 changes: 6 additions & 0 deletions tests/outlineCompiler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,12 @@ def test_compile_with_custom_postscript_names_notdef_preserved(
"lll",
]

def test_empty_postscript_names_no_rename(self, testufo):
testufo.lib["public.postscriptNames"] = {}
original_order = compileTTF(testufo, useProductionNames=False).getGlyphOrder()
result = compileTTF(testufo).getGlyphOrder()
assert result == original_order

def test_warn_name_exceeds_max_length(self, testufo, caplog):
long_name = 64 * "a"
testufo.newGlyph(long_name)
Expand Down
Loading