Skip to content

Fix trailing space in nameID=4 when styleName is empty #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthrotype merged 1 commit into from
Apr 27, 2026
Merged

Fix trailing space in nameID=4 when styleName is empty #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/ufo2ft/outlineCompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ def setupTable_name(self):
preferredSubfamilyName = getAttrWithFallback(
font.info, "openTypeNamePreferredSubfamilyName"
)
fullName = f"{preferredFamilyName} {preferredSubfamilyName}"
fullName = f"{preferredFamilyName} {preferredSubfamilyName}".strip()

nameVals = {
0: getAttrWithFallback(font.info, "copyright"),
Expand Down
10 changes: 10 additions & 0 deletions tests/outlineCompiler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,16 @@ def test_setupTable_name(self, quadufo):
actual = compiler.otf["name"].getName(1, 3, 1, 1033).string
assert actual == "Custom Name for Windows"

def test_setupTable_name_empty_styleName(self, quadufo):
"""nameID=4 (full name) should not have trailing space when styleName is empty."""
quadufo.info.styleName = ""
quadufo.info.styleMapFamilyName = None
quadufo.info.openTypeNamePreferredSubfamilyName = None
compiler = OutlineTTFCompiler(quadufo)
compiler.compile()
fullName = compiler.otf["name"].getName(4, 3, 1, 1033).string
assert fullName == fullName.strip()

def test_post_underline_without_public_key(self, quadufo):
compiler = OutlineTTFCompiler(quadufo)
compiler.compile()
Expand Down
Loading