Don't do autoUseMyMetrics by default for variable fonts#940
Merged
Conversation
same as googlefonts/fontmake#1154, for when ufo2ft is called programmatically as opposed to through fontmake CLI
Member
Author
|
changing a default value (autoUseMyMetrics from False to True for interpolatable/variable builds) is a breaking change in theory, but I'd argue that this is more like a bug fix. The current implementation of computing the USE_MY_METRICS for each individual master independently from one another is what lead to the bug that fonttools/fonttools#3912 is working around. It was a benign bug most of the time, because the presence of HVAR usually prevents these incorrect flags to actually interfere with glyph horizontal metrics and it's only when deliberately removing HVAR that it surfaces. |
cmyr
approved these changes
Aug 27, 2025
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
works for me, not sure if it's worth getting a +1 from someone who spends more time in this repo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as googlefonts/fontmake#1154, for when ufo2ft is called programmatically as opposed to through fontmake CLI