Discovery samples: Ensure the last element of the Java import path is capitalized - #151
Open
vchudnov-g wants to merge 3 commits into
Open
Discovery samples: Ensure the last element of the Java import path is capitalized#151vchudnov-g wants to merge 3 commits into
vchudnov-g wants to merge 3 commits into
Conversation
vchudnov-g
added
the
type: bug
googlebot
added
the
cla: yes
vam-google
approved these changes
Jun 5, 2020
| Joiner.on('.').join(packagePrefix, capitalize(apiTypeName))); | ||
| } | ||
|
|
||
| public static String capitalize(String str) { |
Contributor
There was a problem hiding this comment.
Should this be public (maybe private is enough, I see it being used from getSErviceTypeName()?
Contributor
Author
|
Argh. Not fully fixed, it turns out. The references to the imported class are still lower-cased. I'll update this PR with a fix. |
Contributor
Author
|
Ok, that should be fixed now. I'll figure out how to add a test before I submit this. |
product-auto-label
Bot
added
the
samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing problems for IAM, since the Discovery file said
"canonicalName" : "iam"and thus the import in the sample readimport ....v1.iam;instead ofimport ....v1.Iam;