This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Multiplication result converted to larger type#197
Open
Shivam7-1 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi @lvandeve Could You Please Review Above PR Thanks & Regards |
Contributor
Author
|
Hi @enh-google Could You Please Review Above PR Thanks & Regards |
Contributor
|
(i only maintain Android's copy of this code, and we only use this file on the host, where we don't enable intsan anyway. i've forwarded this -- and the bug -- to the real zopfli maintainers internally though.) |
Contributor
Author
|
Hi @enh-google Okay Thanks 👍 |
Contributor
Author
|
Hi @lvandeve Could You Please Review Above PR Thanks & Regards |
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address the potential overflow issue in the multiplication of w * h * (bit16 ? 8 : 4) and casting it to size_t, I had perform the multiplication using size_t directly to avoid the overflow.
patch link: https://issuetracker.google.com/issues/322327444
Code modification ensures that the multiplication is done using the larger integer type (size_t) before casting the result to unsigned char*. Using size_t for the multiplication helps prevent overflow issues, as size_t is typically large enough to accommodate the size of memory in the system.