Skip to content

internal/driver: guard BuildID slice in locateBinaries to prevent panic on short BuildID #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalexand merged 1 commit into from
May 7, 2026
+7 −1
Merged

internal/driver: guard BuildID slice in locateBinaries to prevent panic on short BuildID #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/driver/fetch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ mapping:
// Llvm buildid protocol: the first two characters of the build id
// are used as directory, and the remaining part is in the filename.
// e.g. `/ab/cdef0123456.debug`
fileNames = append(fileNames, filepath.Join(path, m.BuildID[:2], m.BuildID[2:]+".debug"))
if len(m.BuildID) >= 2 {
fileNames = append(fileNames, filepath.Join(path, m.BuildID[:2], m.BuildID[2:]+".debug"))
}
}
if m.File != "" {
// Try both the basename and the full path, to support the same directory
Expand Down
4 changes: 4 additions & 0 deletions internal/driver/fetch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ func TestSymbolizationPath(t *testing.T) {
{"", "", "fghij10001", filepath.Join(tempdir, "pprof/binaries/fg/hij10001.debug"), 0},
{"/nowhere:/alternate/architecture", "/usr/bin/binary", "fedcb10000", "/usr/bin/binary", 1},
{"/nowhere:/alternate/architecture", "/usr/bin/binary", "abcde10002", "/usr/bin/binary", 1},
// A single-character BuildID must not panic when the LLVM debug-file
// lookup slices BuildID[:2] / BuildID[2:]. Prior to the fix, this caused
// a "slice bounds out of range" panic.
{"", "/usr/bin/binary", "X", "/usr/bin/binary", 0},
} {
os.Setenv("PPROF_BINARY_PATH", tc.env)
p := &profile.Profile{
Expand Down
Loading