AVDTP: Avoid explicit in_use management#928
Open
zxzxwu wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
cc @laozhuxinlu |
uier
reviewed
May 22, 2026
| seid=seid, | ||
| media_type=media_type, | ||
| tsep=tsep, | ||
| in_use=0, |
Collaborator
There was a problem hiding this comment.
It seems LocalStreamEndPoint wont use the in_use and will compute the in_use based on steam state. But it's a required field in SteamEndPoint... I think it's okay, just feel a bit redundant here.
Collaborator
Author
There was a problem hiding this comment.
I turned to make SteamEndPoint an ABC without __init__, so we don't need to init _in_use at all.
cc @barbibulle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate in_use to a property checking if stream state is IDLE.