Refine dependencies - #897
Conversation
|
Maybe avatar and pandora should be removed from |
|
I think it's a great idea to make the dependencies more modular. It seems that dependency groups are usually intended for developer-focused options (doc, tests, ...) not end users. So, for instance, transports would not really be a dependency group. Those would be optional dependencies. |
ffcd751 to
1e6ba31
Compare
|
I think this PR goes in the right direction. It is unfortunate that there isn't a way to specify a "default" for when no optional dependencies are specified, so this will create a breaking change for users, which we'll have to deal with by documenting the change well, and maybe also trying to print out useful errors when we can. |
|
For now I will just separate |
|
Oh, you folks are so awesome: now I don't have to pull in this heavy grpcio/protobuf stuff for nothing. And thank you so much for Bumble! Owing to it, I was able to implement RFCOMM support in my Python library in no time... and it's much more stable and pleasant to use than some other Bluetooth libraries I tried in the past. P.S. The only "issue" I encountered so far is that provided virtual HCI doesn't answer inquiries and support pairing/encryption, which is limiting for testing - but this comment doesn't belong to this ticket :) and you probably know about it and have your reasons anyways. |
[dependency-groups]androidgroupalloption including all other options