Add DevMode runtime safeguards: loopback enforcement, remote-addr filter, and warning banner#54
Draft
Copilot wants to merge 2 commits into
Draft
Add DevMode runtime safeguards: loopback enforcement, remote-addr filter, and warning banner#54Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…nd warning banner Co-authored-by: goodtune <286798+goodtune@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add runtime safeguards for dev mode in authentication
Add DevMode runtime safeguards: loopback enforcement, remote-addr filter, and warning banner
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev_mode: trueenables/auth/test-login(unauthenticated session creation for any username/role) with no runtime guard beyond the config flag itself — trivially enabled in prod viaGHP_DEV_MODE=true.Changes
Startup loopback check (
internal/server/server.go,cmd/ghp/serve.go)Run()now refuses to start in dev mode when the listen address is not a loopback (127.0.0.1,::1,localhost); all-interfaces binds (:8080,0.0.0.0:*) are rejected--force-dev-modeflag added toghp serveto explicitly override the check (e.g. for integration test environments)Remote-addr gate on
/auth/test-login(internal/auth/auth.go)handleTestLoginrejects with403 Forbiddenany request whoseRemoteAddris not a loopback IP, independent of the startup check — defense in depth if--force-dev-modeis usedDev mode warning banner (web templates +
internal/web/handler.go)DevModeis now passed into every template render contextTests
TestHandleTestLogin_{BodyTooLarge,InvalidJSON}updated to set a loopbackRemoteAddrTestHandleTestLogin_NonLoopbackRejected,TestIsLoopbackRemoteAddr,TestIsLoopbackListenAddrTestHelpOutput_Serveextended to assert--force-dev-modeappears in help outputOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.