Skip to content

gopls: prevent crash in ExtractToNewFile when bounds are invalid #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmSach wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

gopls: prevent crash in ExtractToNewFile when bounds are invalid #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gopls/internal/golang/extracttofile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,16 @@ func ExtractToNewFile(ctx context.Context, snapshot *cache.Snapshot, fh file.Han
end += token.Pos(spaces)
pgf.CheckPos(end) // #70553
if !(start <= end) {
bug.Reportf("start: not before end")
return nil, bug.Errorf("start: not before end")
}
// Inv: end is valid wrt pgf.Tok; env >= start.
fileStart := pgf.File.FileStart
pgf.CheckPos(fileStart) // #70553
if !(0 <= start-fileStart) {
bug.Reportf("start: out of bounds")
if !(0 <= int(start-fileStart)) {
return nil, bug.Errorf("start: out of bounds")
}
if !(int(end-fileStart) <= len(pgf.Src)) {
bug.Reportf("end: out of bounds")
return nil, bug.Errorf("end: out of bounds")
}
// Inv: 0 <= start-fileStart <= end-fileStart <= len(Src).
src := pgf.Src[start-fileStart : end-fileStart]
Expand Down