go/analysis/passes/gofmt: add gofmt analyzer by cblecker · Pull Request #621 · golang/tools

cblecker · 2026-03-05T22:20:27Z

Add a new analysis.Analyzer that reports lines whose formatting
differs from gofmt's. Each diagnostic includes a suggested fix
to apply the correct formatting.

The analyzer uses format.Source to format each file, then
diff.Lines to compute line-level edits. Generated files
(ast.IsGenerated) are skipped.

It is registered in gopls as non-default (opt-in) with
informational severity, similar to other style-oriented
analyzers.

Fixes golang/go#77910

gopherbot · 2026-03-05T22:33:22Z

This PR (HEAD: 2da2e04) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/752020.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-05T22:53:51Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T19:45:42Z

Message from Madeline Kalil:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T19:56:00Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-18T19:34:24Z","revision":"b3d97de5013e03a1fcf8ba665fe0a6e4446d890a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T19:56:01Z

Message from Madeline Kalil:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:06:30Z

Message from Madeline Kalil:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_3771561>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:06:31Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64-race has failed with summary (view all results):

go on master (commit a61fd42) / tools on master (change 752020)

To reproduce, try gomote repro 8686964102942460609.

Additional links for debugging:

test golang.org/x/tools/gopls module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:06:32Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:06:32Z

Message from Madeline Kalil:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:30:59Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-18T19:52:48Z","revision":"b3d97de5013e03a1fcf8ba665fe0a6e4446d890a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:31:00Z

Message from Madeline Kalil:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_3771561>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:31:00Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-18T20:31:01Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-19T15:33:43Z

This PR (HEAD: cf03fbe) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/752020.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-19T15:45:04Z

This PR (HEAD: 6030ddb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/752020.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-19T16:06:53Z

Message from Christoph Blecker:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/752020.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-04-14T19:51:05Z

This PR (HEAD: 883b46f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/752020.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Add a new analysis.Analyzer that reports lines whose formatting differs from gofmt's. Each diagnostic includes a suggested fix to apply the correct formatting. The analyzer is registered in gopls as non-default (opt-in) with informational severity, similar to other style-oriented analyzers. Signed-off-by: Christoph Blecker <admin@toph.ca>

Make the gofmt analyzer unexported since new public API requires a proposal. Use the goplsexport trick (as with StdIterators) to make it available to gopls. Signed-off-by: Christoph Blecker <admin@toph.ca>

gopherbot · 2026-04-27T20:15:01Z

This PR (HEAD: 6b8ae3a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/752020.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

cblecker mentioned this pull request Mar 5, 2026

x/tools/gopls: add analyzer to report when code isn't gofmt'd properly golang/go#77910

Open

cblecker force-pushed the add-gofmt-analyzer branch from cf03fbe to 6030ddb Compare March 19, 2026 15:35

cblecker force-pushed the add-gofmt-analyzer branch from 6030ddb to 883b46f Compare April 14, 2026 19:41

cblecker force-pushed the add-gofmt-analyzer branch from 883b46f to 53dd6c7 Compare April 27, 2026 20:10

cblecker added 2 commits April 27, 2026 13:12

go/analysis/passes/gofmt: unexport Analyzer, use goplsexport

6b8ae3a

Make the gofmt analyzer unexported since new public API requires a proposal. Use the goplsexport trick (as with StdIterators) to make it available to gopls. Signed-off-by: Christoph Blecker <admin@toph.ca>

cblecker force-pushed the add-gofmt-analyzer branch from 53dd6c7 to 6b8ae3a Compare April 27, 2026 20:12

Conversation

cblecker commented Mar 5, 2026

Uh oh!

gopherbot commented Mar 5, 2026

Uh oh!

gopherbot commented Mar 5, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 18, 2026

Uh oh!

gopherbot commented Mar 19, 2026

Uh oh!

gopherbot commented Mar 19, 2026

Uh oh!

gopherbot commented Mar 19, 2026

Uh oh!

gopherbot commented Apr 14, 2026

Uh oh!

gopherbot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants