Skip to content

language: count underscores in the ParseAcceptLanguage size limit#67

Open
mohammadmseet-hue wants to merge 1 commit into
golang:masterfrom
mohammadmseet-hue:fix-acceptlanguage-underscore-limit
Open

language: count underscores in the ParseAcceptLanguage size limit#67
mohammadmseet-hue wants to merge 1 commit into
golang:masterfrom
mohammadmseet-hue:fix-acceptlanguage-underscore-limit

Conversation

@mohammadmseet-hue

@mohammadmseet-hue mohammadmseet-hue commented Jul 4, 2026

Copy link
Copy Markdown

ParseAcceptLanguage limits the number of dashes in its input to 1000 to
bound the quadratic-time cost of the tag scanner on untrusted input
(CVE-2022-32149, golang/go#56152). The scanner also treats '' as a
subtag separator, normalizing it to '-' before scanning, but the limit
counts only '-'. Input that uses '
' as its separators therefore
contains no dashes and is not subject to the limit, so it can still
reach the quadratic scanner.

Count '_' as well as '-' when enforcing the limit, and add a regression
test.

Updates golang/go#56152

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 852b565) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/796920.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/796920.
After addressing review feedback, remember to publish your drafts!

ParseAcceptLanguage limits the number of dashes in its input to 1000 to
bound the quadratic-time cost of the tag scanner on untrusted input
(CVE-2022-32149, golang/go#56152). The scanner also treats '_' as a
subtag separator, normalizing it to '-' before scanning, but the limit
counts only '-'. Input that uses '_' as its separators therefore
contains no dashes and is not subject to the limit, so it can still
reach the quadratic scanner.

Count '_' as well as '-' when enforcing the limit, and add a regression
test.

Updates golang/go#56152
@mohammadmseet-hue mohammadmseet-hue force-pushed the fix-acceptlanguage-underscore-limit branch from 852b565 to c672e32 Compare July 4, 2026 03:25
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: c672e32) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/796920.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants