language: count underscores in the ParseAcceptLanguage size limit#67
Open
mohammadmseet-hue wants to merge 1 commit into
Open
language: count underscores in the ParseAcceptLanguage size limit#67mohammadmseet-hue wants to merge 1 commit into
mohammadmseet-hue wants to merge 1 commit into
Conversation
Contributor
|
This PR (HEAD: 852b565) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/796920. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/796920. |
ParseAcceptLanguage limits the number of dashes in its input to 1000 to bound the quadratic-time cost of the tag scanner on untrusted input (CVE-2022-32149, golang/go#56152). The scanner also treats '_' as a subtag separator, normalizing it to '-' before scanning, but the limit counts only '-'. Input that uses '_' as its separators therefore contains no dashes and is not subject to the limit, so it can still reach the quadratic scanner. Count '_' as well as '-' when enforcing the limit, and add a regression test. Updates golang/go#56152
852b565 to
c672e32
Compare
Contributor
|
This PR (HEAD: c672e32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/796920. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseAcceptLanguage limits the number of dashes in its input to 1000 to
bound the quadratic-time cost of the tag scanner on untrusted input
(CVE-2022-32149, golang/go#56152). The scanner also treats '' as a
subtag separator, normalizing it to '-' before scanning, but the limit
counts only '-'. Input that uses '' as its separators therefore
contains no dashes and is not subject to the limit, so it can still
reach the quadratic scanner.
Count '_' as well as '-' when enforcing the limit, and add a regression
test.
Updates golang/go#56152