Fix flate reader reset#222
Conversation
| // ReadResetter is an optional interface that Decompressor can implement. | ||
| type ReadResetter interface { | ||
| Reset(io.Reader) | ||
| Reset(io.Reader, []byte) error |
There was a problem hiding this comment.
Looks like this change isn't back compatible. Do we need to change public API?
|
Can you explain what this fixes and how? |
|
@cristaloleg Sorry I should have explained it in the PR. Why do you think that it's not backwards compatible and requires public API change? It doesn't seem like it to me from first glance. (Edit: oh you mean change to the ReadResetter interface? Yes, I suppose there is not an easy way to get around that other than perhaps creating a new one/a new path) |
Thanks for the great lib!
Here is a small fix