fix: register instrumented driver per-connection instead of per-driver-type#869
Open
lihan3238 wants to merge 1 commit intogobuffalo:mainfrom
Open
fix: register instrumented driver per-connection instead of per-driver-type#869lihan3238 wants to merge 1 commit intogobuffalo:mainfrom
lihan3238 wants to merge 1 commit intogobuffalo:mainfrom
Conversation
…r-type Previously, instrumentDriver() used sql.Register() with a driver name based on the driver type (e.g. instrumented-sql-driver-postgres). This meant that multiple connections using the same driver type but different instrumentation options would all share the first connection options. Replace sql.Register + sql.Open with sql.OpenDB using a per-connection driverConnector, so each connection gets its own wrapped driver with its own options. Fixes gobuffalo#725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #725
Summary
Context
The old code registered instrumented drivers globally per driver type (e.g., instrumented-sql-driver-postgres). When two connections used the same driver type with different instrumentation options, only the first connections options were applied. This fix creates a per-connection wrapped driver instead.
Test plan