fix: encode DEL (0x7f) control character#17
Merged
Conversation
Member
|
Thanks. |
ChrisHines
approved these changes
Sep 25, 2025
Member
|
I'll probably tag a new release soon to get this published. |
Member
|
@spaceone It looks like I approved and merged this too quickly. GitHub had deactivated the CI workflows because the repo hasn't had any changes recently. After re-enabling them there is a test failure. See: https://github.com/go-logfmt/logfmt/actions/runs/18050577904/job/51371519322 It looks like the extra rune value landed in the wrong function. It should be in |
Contributor
Author
|
if you enable the CI workflows again, yes. I don't know how to test/execute this all. |
spaceone
added a commit
to spaceone/logfmt
that referenced
this pull request
Sep 27, 2025
spaceone
added a commit
to spaceone/logfmt
that referenced
this pull request
Sep 27, 2025
Member
|
You can test locally by running |
Contributor
Author
|
→ tests pass with #18 |
spaceone
added a commit
to spaceone/logfmt
that referenced
this pull request
Sep 28, 2025
spaceone
added a commit
to spaceone/logfmt
that referenced
this pull request
Sep 29, 2025
encode DEL control characters in values, and remove them from keys. Fixes: 3f5ba89
ChrisHines
pushed a commit
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\x7f→"\u007f"