Clear text selection when search string is emptied#588
Open
chall37 wants to merge 1 commit into
Open
Conversation
When the search string is emptied, clearHighlights removes the highlight map but leaves the text selection created by findOnPageSelectRange. This causes the first matching character to remain visually selected after all search highlights are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you type a search string and delete it character by character, the first matching character stays selected after the search box is empty. It looks like
findViewControllerClearSearchclears the highlight map but not the text selection that was placed on the current match. Adding aclearSelectioncall clears it.Note: This change also clears selection when closing the Find Bar.