Fix inconsistent bottom padding in split panes#529
Open
csmarshall wants to merge 1 commit into
Open
Conversation
When a terminal window is split into panes, the text positioning is now calculated from the bottom up instead of top down. This ensures that all panes have consistent bottom padding equal to the configured margin (kPreferenceKeyTopBottomMargins), with any excess pixels that don't fit evenly into line heights placed at the top rather than the bottom. Previously, integer division when calculating rows from height would place excess pixels at the bottom, causing visual misalignment between panes when heights didn't divide evenly by line height. Changes: - Modified visibleRectExcludingTopMargin:startingAtRow: in PTYTextView.m to add a top offset equal to (excess - bottomMargin), aligning text from the bottom - Updated comments in the excess method to reflect its new usage for calculating top offset 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
I suspect this will cause many bugs. For example, anywhere that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a terminal window is split into panes, the text positioning is now calculated from the bottom up instead of top down. This ensures that all panes have consistent bottom padding equal to the configured margin (kPreferenceKeyTopBottomMargins), with any excess pixels that don't fit evenly into line heights placed at the top rather than the bottom.
Previously, integer division when calculating rows from height would place excess pixels at the bottom, causing visual misalignment between panes when heights didn't divide evenly by line height.
Changes:
🤖 Generated with Claude Code