Skip to content

Add the inlay package#261

Open
kkostov wants to merge 1 commit into
gleam-lang:mainfrom
kkostov:feat/add-inlay
Open

Add the inlay package#261
kkostov wants to merge 1 commit into
gleam-lang:mainfrom
kkostov:feat/add-inlay

Conversation

@kkostov

@kkostov kkostov commented May 24, 2026

Copy link
Copy Markdown

Adds the inlay package to the Frontend section.

@lpil

lpil commented May 26, 2026

Copy link
Copy Markdown
Member

Cool, thanks!

Is the package ready? It seems there's some incomplete type definitions that have no purpose with the published version: https://github.com/kkostov/inlay/blob/b8813ffb71612fe4be5e336d55f20dc6aabc7d88/src/inlay/embed.gleam#L90-L96

Most the documentation is missing, so it's not clear to me as a reader what anything is or how it should be used. Could you document the public API please 🙏

There's a lot of very small modules, a pluralised module name segment, and grouping by design pattern for "providers", all of which are not idiomatic Gleam.

Would it be possible to adopt the Gleam conventions? Would be fab for the "awesome" libraries to be good references for people learning Gleam.

@kkostov

kkostov commented May 26, 2026

Copy link
Copy Markdown
Author

Oh thanks for the review. I will sort this out!

@lpil

lpil commented May 26, 2026

Copy link
Copy Markdown
Member

Thank you!! 🤩

@kkostov

kkostov commented May 28, 2026

Copy link
Copy Markdown
Author

This was a very fun and educational exercise - I should've done it when I started learning about Gleam 🤩. inlay v2 is out with some API improvements and cleanups kkostov/inlay#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants