Skip to content

fix(commands): remove IsHidden property from UseGithubStorage option #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshjohanning wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(commands): remove IsHidden property from UseGithubStorage option #1522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08c455b
fix(commands): remove IsHidden property from UseGithubStorage option
joshjohanning Mar 3, 2026
06be10c
test: update use-github-storage option verification to remove hidden …
joshjohanning Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/bbs2gh/Commands/GenerateScript/GenerateScriptCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ public GenerateScriptCommand() : base(

public Option<bool> UseGithubStorage { get; } = new("--use-github-storage")
{
IsHidden = true,
Description = "Enables multipart uploads to a GitHub owned storage for use during migration. " +
"Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).",
};
Expand Down
3 changes: 1 addition & 2 deletions src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,7 @@ public MigrateRepoCommand() : base(
public Option<bool> UseGithubStorage { get; } = new(
name: "--use-github-storage",
description: "Enables multipart uploads to a GitHub owned storage for use during migration. " +
"Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).")
{ IsHidden = true };
"Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).");

public override MigrateRepoCommandHandler BuildHandler(MigrateRepoCommandArgs args, IServiceProvider sp)
{
Expand Down
1 change: 0 additions & 1 deletion src/gei/Commands/GenerateScript/GenerateScriptCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ public GenerateScriptCommand() : base(
{ IsHidden = true };
public Option<bool> UseGithubStorage { get; } = new("--use-github-storage")
{
IsHidden = true,
Description = "Enables multipart uploads to a GitHub owned storage for use during migration. " +
"Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).",
};
Expand Down
1 change: 0 additions & 1 deletion src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ public MigrateRepoCommand() : base(
};
public Option<bool> UseGithubStorage { get; } = new("--use-github-storage")
{
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a user-visible CLI change (the --use-github-storage flag will now appear in --help). Per the contribution guidelines, user-noticeable changes should include a bullet in RELEASENOTES.md; please add an entry describing that this option is no longer hidden / is now generally available.

Suggested change
{
{
IsHidden = true,

Copilot uses AI. Check for mistakes.
IsHidden = true,
Description = "Enables multipart uploads to a GitHub owned storage for use during migration. " +
"Configure chunk size with the GITHUB_OWNED_STORAGE_MULTIPART_MEBIBYTES environment variable (default: 100 MiB, minimum: 5 MiB).",
};
Expand Down
Loading