fix(keyservice): return error for unsupported master key types#2220
Open
santosh7676 wants to merge 2 commits into
Open
fix(keyservice): return error for unsupported master key types#2220santosh7676 wants to merge 2 commits into
santosh7676 wants to merge 2 commits into
Conversation
Signed-off-by: Santosh Mahale <santoshmahale7676@gmail.com>
492ba3d to
838d779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyservice.KeyFromMasterKeywhen encountering an unknownkeys.MasterKeytype with explicit error handling.KeyFromMasterKeyOrErrorandErrUnsupportedMasterKeyTypefor callers that need to handle unsupported key types safely.sops.goto propagate conversion errors instead of crashing the process.KeyFromMasterKeypreviously panicked on unknown master key types. That can crash SOPS during encrypt/decrypt operations instead of returning a recoverable error. This change makes failure behavior consistent with the rest of the key handling flow.Behavior change
MasterKeytype -> process panic.MasterKeytype -> returned error (ErrUnsupportedMasterKeyType) and normal error propagation in encrypt/decrypt paths.