-
-
Notifications
You must be signed in to change notification settings - Fork 468
[DNM] Add Develocity build scan plugin #5379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
e84a32e
9b87d20
f46bf81
0d72252
6fad2ab
72134fd
4805aae
d89823c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,18 @@ pluginManagement { | |
| } | ||
| } | ||
|
|
||
| plugins { | ||
| id("com.gradle.develocity") version "4.4.1" | ||
| } | ||
|
|
||
| develocity { | ||
| buildScan { | ||
| termsOfUseUrl.set("https://gradle.com/help/legal-terms-of-use") | ||
| termsOfUseAgree.set("yes") | ||
| publishing.onlyIf { true } | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Build scans unconditionally published to external serviceMedium Severity The Develocity configuration uses Reviewed by Cursor Bugbot for commit 9b87d20. Configure here. |
||
|
|
||
| dependencyResolutionManagement { | ||
| repositories { | ||
| google() | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The Develocity configuration unconditionally publishes build scans to a public server for all builds, including local ones, exposing potentially sensitive environment data.
Severity: HIGH
Suggested Fix
Modify the
publishing.onlyIfcondition to only be true for CI/CD environments, not local builds. For example, check for a specific environment variable likeCI. This will prevent local developer build data from being publicly uploaded.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.