Add specific crash message for OOMs#7273
Open
seadowg wants to merge 11 commits into
Open
Conversation
grzesiek2010
requested changes
Jun 23, 2026
grzesiek2010
requested changes
Jun 23, 2026
| } | ||
| } | ||
|
|
||
| null -> null |
Member
There was a problem hiding this comment.
If decode fails, getCrash returns null while hasCrashed() stays true, so KEY_CRASH is never cleared and the app bounces to the crash screen on every launch.
Member
Author
There was a problem hiding this comment.
Good catch! I've convert hasCrashed to an extension (that just uses the getCrash value) to prevent that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6859
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue, this doesn't actually fix the crash, but does add a new specific crash message when the app crashes due to an
OutOfMemoryError. This won't catch every out of memory problem (as it can result in a range of side effect exceptions), but it should improve the error flow for a lot fo them.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Nothing to test here - good for a reviewer to try and validate this by hacking an OOM into the app.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest