-
Notifications
You must be signed in to change notification settings - Fork 134
Add brew installation notice to the README
#991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,22 @@ to reuse the same client components across different applications and deployment | |
| Floresta is the Portuguese word for forest. It is a reference to the Utreexo accumulator, | ||
| which is a forest of Merkle trees. It's pronounced _/floˈɾɛstɐ/_. | ||
|
|
||
| ## Running | ||
|
|
||
| Currently, Floresta is only available for installation on Linux and MacOS via | ||
| the [`brew`](https://formulae.brew.sh/formula/floresta) package manager. | ||
|
|
||
| To install and run it: | ||
|
|
||
| ```shell | ||
| ~$ brew install floresta | ||
|
|
||
| ~$ florestad | ||
| ``` | ||
|
|
||
| Alternatively, you can build it from source. Refer to the build instructions | ||
| for [Unix](doc/build-unix.md) or [MacOS](doc/build-macos.md). | ||
|
|
||
|
Comment on lines
+49
to
+64
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry but i dont think install instructions should be on README like that, it should be on
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to pretty much overhaul all documentation. This should be on the main page so people can go to the repo and immediately see how to install it using a package manager. It's succinct, so no need to have that there.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That could be discussed in a proper PR or issue for that, the current design for documentation follows a parity with how bitcoin core document things, the current structure was already achieved by an "overhaul" not so long time ago.
I agree with you in the point where this should be clearly exposed but we have a structure to follow here in what concerns documentation, changing things on the go will not provide us any stability or any structure to stick with. |
||
| ## Architecture | ||
|
|
||
| Floresta is written in Rust and implements modern Bitcoin validation techniques such as | ||
|
|
@@ -61,10 +77,6 @@ reusable components that can be integrated into Bitcoin applications. | |
| [`libfloresta`](https://github.com/getfloresta/Floresta/tree/master/crates) to provide a full node | ||
| daemon, including a watch-only wallet and an Electrum server. | ||
|
|
||
| If you only want to run a node, you can use | ||
| [`florestad`](https://github.com/getfloresta/Floresta/tree/master/bin/florestad) by building it from | ||
| source, following the instructions for [Unix](doc/build-unix.md) or [MacOS](doc/build-macos.md). | ||
|
|
||
| ## Consensus Implementation | ||
|
|
||
| One of the most challenging parts of working with Bitcoin is keeping up with the consensus rules. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simply not true, installing it trough cargo is broken but you can install it following
doc/installing.mdusing the install script and even using nix too (The way i use it on my setup)...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
cargo install florestawork? There's no usable published package oncrates.ioyet. I don't considercargo install --git <$FLORESTA_REPO>as installing through a package manager.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#991 (comment)