rpcserver: Support named and null parameters, Review optionals on rpc internal methods, Stronger Response and Error codes by jaoleal · Pull Request #831 · getfloresta/Floresta

jaoleal · 2026-02-06T20:51:16Z

Description and Notes

Some time ago i was messing with the server trying to fix some pains that i had developing methods on it and i encountered some points to upgrade.

4839dc6 - fixes #827 by matching errors and returning constant values, i also mapped some custom error codes to internal errors as I understood that were allowed by the spec.

29220da- Adds named and null parameters support, I also reviewed some Options in internal rpc methods that actually had internal defaults, created a getter for that case.

fix #827
fix #704

How to verify the changes you have done?

Pushed some extensive tests regarding request and result parsing and behavior, checking that calls are accepted when expected and when refused we assert the error response.

Contributor Checklist

I've followed the contribution guidelines
I've verified one of the following:
- Ran just pcc (recommended but slower)
- Ran just lint-features '-- -D warnings' && cargo test --release
- Confirmed CI passed on my fork
I've linked any related issue(s) in the sections above

Finally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).

jaoleal · 2026-02-06T20:53:48Z

cc @csgui

Why i cant alter the name of the PR 😭

jaoleal · 2026-02-06T23:28:05Z

Can someone with permission to alter the pr title fix it for me ?

rpcserver: Support named and null parameters, Review optionals on rpc internal methods, Stronger Response and Error codes.

jaoleal · 2026-02-06T23:33:55Z

5cd9007 Unrelated test fail

csgui · 2026-02-08T20:05:16Z

@jaoleal double check if you can use <T: DeserializeOwned> or <'de, T: Deserialize<'de>>. Not both, choose one.

That would makes more sense and allows the remove of clone in the code. When parsing RPC parameters clone can cause performance issues and increased memory pressure under heavy load. We do not have control on what Floresta user is passing to a RPC call.

jaoleal · 2026-02-09T09:25:48Z

top commit: 0e160f5

Removed a clone from get_at, lifetime matching solved that.
Included back MempoolAccept, sorry conflict problems.
Fixed a bug matching against params in get_arr_at where it would result unwrapping in a malformed input.
Added extensive tests, they were written by claudiao but i reviewed it and found a bug.
Fixed a bug when an optional parameter is omitted when params are omitted as a whole.

Thanks for the suggestions @csgui

moisesPompilio · 2026-02-09T13:43:13Z

I think the commit descriptions are missing because they only have titles.

jaoleal · 2026-02-09T19:08:38Z

[781ea91 Rebased and extended commit message with descriptions.

jaoleal · 2026-02-09T19:39:32Z

Added formal fix statement for the issues that this pr fixes.

jaoleal · 2026-02-10T18:17:14Z

gaddamit these conflicts

jaoleal · 2026-02-10T21:17:49Z

unrelated fail on functional tests d18e6dd

lorenzolfm

ACK 784bf23

jaoleal · 2026-05-15T17:38:10Z

Rebased

jaoleal · 2026-05-18T12:53:08Z

Rebased 4dc5b8a

jaoleal · 2026-05-18T18:02:05Z

Ok, I remade the commit structure, theyre more concentrated now but i think its better.

Fixed the marked found by @moisesPompilio

Davidson-Souza · 2026-05-21T18:51:08Z

Needs rebase.

jaoleal · 2026-05-25T19:27:13Z

Rebased

jaoleal · 2026-05-26T14:59:00Z

Rebased

jaoleal · 2026-05-27T17:31:50Z

Rebased

jaoleal · 2026-05-27T20:41:23Z

Removed unwrap from getdifficulty

jaoleal · 2026-06-01T17:00:30Z

Done @moisesPompilio

csgui

@jaoleal left a comment regarding the gettxoutproof changes. Can you please check?

jaoleal · 2026-06-01T19:05:58Z

@jaoleal left a comment regarding the gettxoutproof changes. Can you please check?

Yeah, it certainly changed because of the removal of .to_lower_hex_string().

I found another issues while trying to test it. I see this problem as something more focused on how gettxoutproof was implemented, this was a existing inconsistency problem that was raised because of the changes from this pr.

Given that, ill open a follow-up pr fixing gettxoutproof inconsistencies that rebases on top of this. Works for you @csgui ?

csgui · 2026-06-01T19:13:22Z

Given that, ill open a follow-up pr fixing gettxoutproof inconsistencies that rebases on top of this. Works for you @csgui ?

Yes, it works @jaoleal . Please open an issue about what need to be tackled on gettxoutproof and mention that it should be covered with better testing. If we had better test coverage, issues like this would be caught much sooner. Tks!

csgui

ACK 311485d

jaoleal · 2026-06-01T19:17:10Z

If we had better test coverage, issues like this would be caught much sooner. Tks!

We could focus some time and work to test and assert on what we current have, to find a problem that way is literally a punch in the stomach.

csgui · 2026-06-01T19:27:19Z

We could focus some time and work to test and assert on what we current have, to find a problem that way is literally a punch in the stomach.

Sure thing. Hardening the tests is on the table for the next plans. That might be our focus soon.

Davidson-Souza · 2026-06-02T15:34:55Z

Needs more rebase 😢

… calls - Move JsonRpcError into a jsonrpc_interface submodule with structured RpcError/Response types, HTTP status code mapping, and named constants for floresta-specific RPC error codes (TX_NOT_FOUND, BLOCK_NOT_FOUND, PEER_NOT_FOUND, etc.) - Add From<BlockchainError> for JsonRpcError conversion - Rewrite arg_parser with generic get_at(), get_with_default(), and try_into_optional() functions supporting both positional (array) and named (object) parameters - Change RpcRequest.params from Vec<Value> to Option<Value> - Split method dispatch into no-param methods and param methods - Replace all .unwrap() calls - Apply #[deny(clippy::unwrap_used)] lint to the json_rpc module - Change ScriptPubKeyJson.address to Option<String> for nonstandard scripts (matching Bitcoin Core behavior) - Add module-level documentation for JSON-RPC 1.0/2.0 version support

- Add JSON-RPC error code (JSONRPC_ERRCODE_*) and message (JSONRPC_ERRMSG_*) constants to test_framework/constants.py - Add make_raw_request, make_raw_data_request, make_request, assert_rpc_success, and assert_rpc_error to test_framework/rpc/base.py - Extract _create_logger helper to deduplicate fixture logging setup - Add class-scoped shared_florestad_node, shared_bitcoind_node, and shared_utreexod_node fixtures to conftest.py - Switch xdist to loadscope distribution for class-scoped fixture safety

- Add comprehensive tests covering positional and named parameters, null/omitted params, optional defaults, error codes and messages, and response structure validation - Add JSON-RPC 1.0 and 2.0 version acceptance tests (explicit version, omitted field, and response format verification) - Add content-type handling tests (application/json, text/plain, and non-JSON body rejection)

jaoleal · 2026-06-02T16:20:04Z

Re based

jaoleal · 2026-06-02T16:21:23Z

last review round guys @csgui @Davidson-Souza @lorenzolfm @moisesPompilio

Davidson-Souza

ACK b80de6a

luisschwab

ACK b80de6a

jaoleal force-pushed the some_fixes_rpcserver branch from 766648c to 5cd9007 Compare February 6, 2026 23:25

Davidson-Souza assigned jaoleal Feb 7, 2026

Davidson-Souza added RPC Changes something with our JSON-RPC interface code quality Generally improves code readability and maintainability labels Feb 7, 2026

Davidson-Souza changed the title ~~rpcserver: Support named and null parameters, Review optionals on rpc internal methods,~~ rpcserver: Support named and null parameters, Review optionals on rpc internal methods, Stronger Response and Error codes Feb 7, 2026

csgui requested changes Feb 7, 2026

View reviewed changes

Comment thread crates/floresta-node/src/json_rpc/request.rs Outdated

csgui requested changes Feb 7, 2026

View reviewed changes

Comment thread crates/floresta-node/src/json_rpc/request.rs Outdated

Comment thread crates/floresta-node/src/json_rpc/request.rs Outdated

Comment thread crates/floresta-node/src/json_rpc/request.rs Outdated

Comment thread crates/floresta-node/src/json_rpc/request.rs Outdated

jaoleal force-pushed the some_fixes_rpcserver branch 2 times, most recently from c13b68a to 0e160f5 Compare February 9, 2026 09:22

jaoleal requested review from Davidson-Souza and moisesPompilio February 9, 2026 09:36

jaoleal force-pushed the some_fixes_rpcserver branch from 0e160f5 to 781ea91 Compare February 9, 2026 19:07

jaoleal force-pushed the some_fixes_rpcserver branch from 781ea91 to 994e4b7 Compare February 10, 2026 01:44

This comment was marked as outdated.

Sign in to view

jaoleal force-pushed the some_fixes_rpcserver branch 4 times, most recently from 2d230a8 to bd4d7a1 Compare February 10, 2026 15:45

jaoleal force-pushed the some_fixes_rpcserver branch from bd4d7a1 to d18e6dd Compare February 10, 2026 20:32

jaoleal requested a review from csgui February 11, 2026 18:07

lorenzolfm reviewed May 15, 2026

View reviewed changes

jaoleal force-pushed the some_fixes_rpcserver branch from 784bf23 to 0f040b6 Compare May 15, 2026 17:37

moisesPompilio reviewed May 18, 2026

View reviewed changes

jaoleal mentioned this pull request May 23, 2026

[Enhancement] Populate other integration tests with shared nodes #1082

Open

moisesPompilio reviewed May 29, 2026

View reviewed changes

Comment thread tests/test_framework/rpc/base.py

Comment thread tests/florestad/rpcserver_request_parsing.py Outdated

csgui reviewed Jun 1, 2026

View reviewed changes

Comment thread crates/floresta-node/src/json_rpc/server.rs

csgui reviewed Jun 1, 2026

View reviewed changes

csgui approved these changes Jun 1, 2026

View reviewed changes

jaoleal added 3 commits June 2, 2026 13:17

Davidson-Souza approved these changes Jun 2, 2026

View reviewed changes

jaoleal mentioned this pull request Jun 2, 2026

fix: inconsitencies on gettxoutproof #1113

Open

luisschwab approved these changes Jun 2, 2026

View reviewed changes

Conversation

jaoleal commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description and Notes

How to verify the changes you have done?

Contributor Checklist

Uh oh!

jaoleal commented Feb 6, 2026

Uh oh!

jaoleal commented Feb 6, 2026

Uh oh!

jaoleal commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csgui commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaoleal commented Feb 9, 2026

Uh oh!

moisesPompilio commented Feb 9, 2026

Uh oh!

jaoleal commented Feb 9, 2026

Uh oh!

jaoleal commented Feb 9, 2026

Uh oh!

This comment was marked as outdated.

jaoleal commented Feb 10, 2026

Uh oh!

jaoleal commented Feb 10, 2026

Uh oh!

lorenzolfm left a comment

Choose a reason for hiding this comment

Uh oh!

jaoleal commented May 15, 2026

Uh oh!

jaoleal commented May 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaoleal commented May 18, 2026

Uh oh!

Davidson-Souza commented May 21, 2026

Uh oh!

jaoleal commented May 25, 2026

Uh oh!

jaoleal commented May 26, 2026

Uh oh!

jaoleal commented May 27, 2026

Uh oh!

jaoleal commented May 27, 2026

Uh oh!

Uh oh!

Uh oh!

jaoleal commented Jun 1, 2026

Uh oh!

Uh oh!

csgui left a comment

Choose a reason for hiding this comment

Uh oh!

jaoleal commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csgui commented Jun 1, 2026

Uh oh!

csgui left a comment

Choose a reason for hiding this comment

Uh oh!

jaoleal commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csgui commented Jun 1, 2026

Uh oh!

jaoleal commented Feb 6, 2026 •

edited

Loading

csgui commented Feb 8, 2026 •

edited

Loading

jaoleal commented Jun 1, 2026 •

edited

Loading

jaoleal commented Jun 1, 2026 •

edited

Loading