feat: add getaddednodeinfo rpc#1114
Draft
jaoleal wants to merge 4 commits into
Draft
Conversation
Add the wire-layer plumbing for the getaddednodeinfo RPC: - AddedNodeInfo struct in node_interface - UserRequest::GetAddedNodeInfo and NodeResponse::GetAddedNodeInfo variants - get_added_node_info() method on NodeInterface - handle_get_added_node_info() implementation in peer_man - Match arm in perform_user_request()
Register the getaddednodeinfo RPC endpoint in the JSON-RPC server: - Add get_added_node_info() handler in network.rs - Register "getaddednodeinfo" route in server.rs - Add RPC documentation
Add getaddednodeinfo to the FlorestaRPC trait and its blanket implementation for JSON-RPC clients. Wire the new method into the floresta-cli binary as a subcommand.
Add Python integration test verifying getaddednodeinfo returns correct information about manually added nodes, and add the get_added_node_info() wrapper to the test framework.
jaoleal
commented
Jun 3, 2026
| let ip = addr_str | ||
| .parse::<IpAddr>() | ||
| .map_err(|_| JsonRpcError::InvalidAddress)?; | ||
| (ip, 8333) |
Member
Author
|
Ill rebase after #1114 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
add get addednodeinfo rpc that returns info about the nodes that were manually added and their addresses and wheter theyre connected.
Split of #916
How to verify the changes you have done?
I tried to cover the basic cases so:
Read & Run integration tests.