Skip optional workers based on port number - #26
Open
jwatzman wants to merge 1 commit into
Open
Conversation
The optional workers in getcord#24 doesn't quite work right: because env variables are always strings, `generate-dotenv.cjs` will set these two new env vars to the string `'false'` -- which is truthy. So the console and admin workers will always be deactivated unless we set the value to the string `''` or similar, which is confusing for these boolean-sounding settings. Instead, we can just check if the port number is set, and skip if not, which is nice that we don't need a new env var -- you can just set the port number to the empty string to deactivate. This does have a similar issue, in that if you set the port to `0'`, it will still try to activate the optional worker -- but `parseListenPort` will immediately yell that `0` is an invalid port so at least you know immediately.
dmmiller
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional workers in #24 doesn't quite work right: because env variables are always strings,
generate-dotenv.cjswill set these two new env vars to the string'false'-- which is truthy. So the console and admin workers will always be deactivated unless we set the value to the string''or similar, which is confusing for these boolean-sounding settings.Instead, we can just check if the port number is set, and skip if not, which is nice that we don't need a new env var -- you can just set the port number to the empty string to deactivate. This does have a similar issue, in that if you set the port to
'0', it will still try to activate the optional worker -- butparseListenPortwill immediately yell that0is an invalid port so at least you know immediately.