fix: fullscreen width + docs for single creative format#70
Open
NicolayKjarnet wants to merge 2 commits intoget-advantage:mainfrom
Open
fix: fullscreen width + docs for single creative format#70NicolayKjarnet wants to merge 2 commits intoget-advantage:mainfrom
NicolayKjarnet wants to merge 2 commits intoget-advantage:mainfrom
Conversation
Fixes fullscreen width on publishers that apply max-width to the iframe (e.g. tv2.no's max-width: 1920px). Also fixes :host positioning in padded ad containers.
Contributor
Author
|
Hey @pattan, noticed that the single creative format doesn't go full-width on publishers that set |
Contributor
|
Thanks for the report @NicolayKjarnet My spontaneous thoughts are that this should lives into publishers integration (tv2), rather than in the format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
DOUBLE_MIDSCROLL_SINGLE_CREATIVEdidn't fill the full viewport width on publishers that applymax-widthconstraints to the iframe (e.g. tv2.no'smax-width: 1920px).Changes:
max-widthwith inline style so the creative always goes full-width:hostpositioning in padded ad containers withmargin-left: calc((100% - 100vw) / 2)Why this is needed:
The standard
DOUBLE_MIDSCROLLavoids this because its background iframe lives inside Shadow DOM, unreachable by page CSS. The single creative variant only has a foreground iframe, so it's subject to publisher constraints. The inline style override fixes this cleanly.Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 license.