feat: RAII wrapper for ProjArea - #262
Open
y1lan wants to merge 1 commit into
Open
Conversation
The normal manually destroy calling cannot cover the error path, which is different from C language where every path is explicitly noted by human. RAII Wapper would help compiler to insert the drop glue correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normal manually destroy calling cannot cover the error path, which
is different from C language where every path is explicitly noted by
human.
RAII Wapper would help compiler to insert the drop glue correctly.
Pick test
test_from_crs_erroras an entry point:function
transform_epsgwould early return, but the resource created byproj_area_createis not released.similar problem happens on function
crs_to_crs_from_pj.CHANGES.mdorCHANGELOG.md