Skip to content

Do not set humanized date when not set #9189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PascalLike wants to merge 5 commits into
base: main
Choose a base branch
from
+14 −18
Open

Do not set humanized date when not set #9189

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4607a77
Do not set humanized date when not set
PascalLike Feb 27, 2026
ba36f1f
Extra scenarios
PascalLike Mar 4, 2026
f5c6189
Show raw date when no humanize date is active
PascalLike Mar 9, 2026
70d4e36
Typo
PascalLike Mar 9, 2026
e0759cc
Remove unnecessary code
PascalLike Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions web-ui/src/main/resources/catalog/components/utility/UtilityService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,36 +594,41 @@
"gnGlobalSettings",
function (gnGlobalSettings) {
return function (date, format, contextAllowToUseFromNow) {
function isDateGmlFormat(date) {
return date.match("[Zz]$") !== null;
}
var settingAllowToUseFromNow = gnGlobalSettings.gnCfg.mods.global.humanizeDates,
timezone = gnGlobalSettings.gnCfg.mods.global.timezone;
const isDateGmlFormat = /[Zz]$/.test(date);
Comment thread
PascalLike marked this conversation as resolved.
Outdated
const isDateTimeFormat = date.includes("T");
var settingAllowToUseFromNow = gnGlobalSettings.gnCfg.mods.global.humanizeDates;
var timezone = gnGlobalSettings.gnCfg.mods.global.timezone;
var parsedDate = null;
if (isDateGmlFormat(date)) {

if (isDateGmlFormat) {
Copy link
Copy Markdown
Contributor

@tylerjmchugh tylerjmchugh Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this if statement is required.

YYYY-MM-DDtHH-mm-SSSZ is not valid anyways. I think moment(date) should work fine in both cases?

parsedDate = moment(date, "YYYY-MM-DDtHH-mm-SSSZ");
} else {
} else if (isDateTimeFormat) {
parsedDate = moment(date);
} else {
parsedDate = moment.utc(date); // Date only
}

if (parsedDate.isValid()) {
if (!!timezone) {
parsedDate = parsedDate.tz(
timezone === "Browser" ? moment.tz.guess() : timezone
Copy link
Copy Markdown
Contributor

@tylerjmchugh tylerjmchugh Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revision date with the recommended/browser timezone should not display as the previous day:

It seems that daylight savings is causing issues here. The editor guesses the timezone is -4 (EDT) correctly but then gnHumanizeTimeService guesses the timezone is -5 (EST) shifting to the previous day. Maybe this should be consistent with how the date input in the editor guesses the timezone?

Copy link
Copy Markdown
Contributor Author

@PascalLike PascalLike Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default gnHumanizeTimeService uses JVM timezone, but time zones definitions can change frequently and need to be updated.
An alternative may be to set a fixed Timezone in the settings, setting it to "Browser", to use the one from the browser (like in the editor) or another fixed value.

);
}
var fromNow = parsedDate.fromNow();

if (date.length === 4) {
format = "YYYY";
}
format = "YYYY"; // Year only format
} // Otherwise defaults to the format provided as input

var fromNow = parsedDate.fromNow();

if (settingAllowToUseFromNow && contextAllowToUseFromNow) {
return {
value: fromNow,
title: format ? parsedDate.format(format) : parsedDate.toString()
title: format ? parsedDate.format(format) : parsedDate.toString(),
value: fromNow
Copy link
Copy Markdown
Contributor

@tylerjmchugh tylerjmchugh Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional? It is not changing any logic. Only the order.

Copy link
Copy Markdown
Contributor Author

@PascalLike PascalLike Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for readability

};
} else {
return {
title: fromNow,
title: isDateTimeFormat ? parsedDate.toString() : fromNow,
Comment thread
PascalLike marked this conversation as resolved.
Outdated
value: format ? parsedDate.format(format) : parsedDate.toString()
};
}
Expand Down
Loading