Skip to content

Fix more typos - #6747

Merged
gassmoeller merged 3 commits into
geodynamics:mainfrom
anne-glerum:fix_typos_0325
May 20, 2026
Merged

Fix more typos#6747
gassmoeller merged 3 commits into
geodynamics:mainfrom
anne-glerum:fix_typos_0325

Conversation

@anne-glerum

@anne-glerum anne-glerum commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix the typos I identified for the workshop yesterday. Some of them have been fixed by the others, so let's wait till those PRs are merged.

bangerth
bangerth approved these changes Oct 31, 2025
View reviewed changes
Comment thread include/aspect/plugins.h
Comment thread source/simulator/parameters.cc Outdated
@bangerth

bangerth commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Do you want to merge this PR, or are you still waiting for other PRs to get merged first?

@bangerth

bangerth commented Nov 22, 2025

Copy link
Copy Markdown
Contributor

@anne-glerum ping?

@anne-glerum

anne-glerum commented Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

Apologies @bangerth! The other PRs were merged and I've rebased, should be ready to merge now.

@anne-glerum

anne-glerum commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bangerth I've rebased again and updated the parameter documentation. I see one problem though. Because I compiled this branch against FastScape, the parameter documentation now also includes FastScape parameters. Should I just revert those additions? (I'll be working on including FastScape in the tester soon.)

@gassmoeller

gassmoeller commented May 12, 2026

Copy link
Copy Markdown
Member

/rebuild

@gassmoeller

gassmoeller commented May 12, 2026

Copy link
Copy Markdown
Member

Very nice, ready to merge when the testers are done.

@gassmoeller

gassmoeller commented May 12, 2026

Copy link
Copy Markdown
Member

Oh, I didnt read your post. Yes please remove the fastscape parameters for now until we have a tester ready.

@anne-glerum

anne-glerum commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Fastscape documentation has been removed. I don't think the failing tester is due to this PR.

@gassmoeller
gassmoeller merged commit c3f03ab into geodynamics:main May 20, 2026
9 checks passed
@anne-glerum
anne-glerum deleted the fix_typos_0325 branch May 20, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bangerth bangerth bangerth approved these changes
@gassmoeller gassmoeller gassmoeller approved these changes

Assignees

No one assigned

Labels

ready to merge ready to test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anne-glerum @bangerth @gassmoeller