chore: Fix flaky unit test - #661
Open
asteiner-swisstopo wants to merge 1 commit into
Open
Conversation
This test fails occasionall with > Property expires can't be in the past. because sometimes it may take more than 100ms between getting the current time and validating the item. To mitigate that, I increased the delta from 100ms to 10m.
github-actions
Bot
added
the
skip-release-note
ltshb
reviewed
Aug 20, 2026
ltshb
left a comment
ltshb
left a comment
Contributor
There was a problem hiding this comment.
Why 10min ? Sounds like a lot more than 100ms, would it not be better to simply increase it a little bit, like 1-3s. 100ms is very short for python creation in DB but it should be able to do it in less than 1min.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails occasionally with
because sometimes it may take more than 100ms between getting the current time and validating the item.
To mitigate that, I increased the delta from 100ms to 10m.