Always update Asset.etag when Asset is updated. - #650
Closed
adk-swisstopo wants to merge 1 commit into
Closed
Conversation
In #648 we modified Asset triggers such that `etag` and `updated` fields are only updated when the underlying file is modified. However we later determined that `etag` should be updated when any field is updated. This change splits the trigger into two: one for the timestamp and one for the ETag. We make the ETag trigger unconditional and update the tests accordingly.
Member
Author
|
Withdrawing in favour of #651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #648 we modified Asset triggers such that
etagandupdatedfields are only updated when the underlying file is modified. However we later determined thatetagshould be updated when any field is updated.This change splits the trigger into two: one for the timestamp and one for the ETag. We make the ETag trigger unconditional and update the tests accordingly.