PB-1403: Add tests for pgtriggers and clean up conditions. - #647
Merged
Conversation
One of the triggers generated by `child_triggers` is meant to update the `updated` j field of the parent whenever the child changes. This is used for the following relationships: item/Asset, collection/CollectionAsset, collection/Item. As part of PB-1403, I plan to modify these triggers. This change adds tests to exercise these triggers. No change in behaviour is expected at this point.
This turns four very redundant methods into one.
Set `db_create=True` everywhere.
The `generates_asset_upload_triggers` function generates a trigger that updates the etag of an AssetUpload whenever any field of that AssetUpload is updated. Before simplifying that trigger, I am adding a test to ensure it keeps working as expected.
The `child_triggers` function is used to generate PostgreSQL triggers to update some fields automatically. Currently it is triggered when any field changes. For PB-1403 we want these triggers to be conditional on specific fields. This change replaces the raw-SQL-based `Condition('OLD.* IS DISTINCT FROM NEW.*')` with `AnyChange(*fields)`. This is equivalent as long as `fields` is empty. We also update `child_triggers` to take a new optional `fields` argument (defaulting to empty). This allows callers to define the conditions that apply for the trigger. A later change will make use of this new parametre. Something similar was done for `auto_variables_triggers` in 02f63bc
The `pgtrigger.Condition('OLD.file_size IS DISTINCT FROM NEW.file_size')`
condition is equivalent to `pgtrigger.AnyChange('file_size')`, which is easier
to inspect and reason about. This change replaces the former with the latter.
The `pgtrigger.Condition('''OLD.proj_epsg IS DISTINCT FROM NEW.proj_epsg''')`
condition is equivalent to `pgtrigger.AnyChange('proj_epsg')`, which is easier
to inspect and reason about. This change replaces the former with the latter.
The `pgtrigger.Condition('OLD.* IS DISTINCT FROM NEW.*')` condition is
equivalent to `pgtrigger.AnyChange()`, which is easier to inspect and reason
about. This change replaces the former with the latter.
The `pgtrigger.Condition('OLD.* IS DISTINCT FROM NEW.*')` condition is
equivalent to `pgtrigger.AnyChange()`, which is easier to inspect and reason
about. This change replaces the former with the latter.
benschs
approved these changes
Jun 4, 2026
adk-swisstopo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of PB-1403 we need to modify several triggers which don't currently have tests. This change adds tests and modifies some of these triggers slightly to replace some raw SQL statements with calls to
pgtrigger.AnyChange. No actual change in behaviour is expected at this stage.