PB-1403: only update asset timestamp when the underlying file has changed. - #645
Closed
adk-swisstopo wants to merge 3 commits into
Closed
PB-1403: only update asset timestamp when the underlying file has changed.#645adk-swisstopo wants to merge 3 commits into
adk-swisstopo wants to merge 3 commits into
Conversation
We have a PostgreSQL trigger that updates the `updated` field of the Asset objects whenever any field in the object is updated. AFAICT there is no test covering this. This change adds a test that verifies that updating the `checksum_multihash` field of the Asset also updates the `updated` field. This is in preparation of changes to that trigger.
The `auto_variables_triggers` function is used to generate PostgreSQL triggers to update some fields automatically. Currently it is triggered when any field changes. For PB-1403 we want at least one of these triggers to be conditional on specific fields. This change replaces the raw-SQL-based `Condition('OLD.* IS DISTINCT FROM NEW.*')` with `AnyChange(fields)`. This is equivalent as long as `fields` is empty. We also update `auto_variables_triggers` to take a new optional `fields` argument (defaulting to empty). This allows callers to define the conditions that apply for the trigger. A later change will make use of this new parametre.
The `updated` field of `Asset` objects is updated when any field is updated. This causes unecessary churn and confusion when hidden metadata are updated. This change ensures the `updated` field is only updated when the `file`, `checksum_multihash` or `file_size` field is updated. This also adds a test to verify the timestamp is not updated when the description is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
updatedfield ofAssetobjects is updated when any field is updated. This causes unecessary churn and confusion when hidden metadata are updated.This change ensures the
updatedfield is only updated when thefile,checksum_multihashorfile_sizefield is updated.This also adds a test to verify the timestamp is not updated when the description is updated.