Deduplicate and simplify Expires header test code. - #643
Merged
Conversation
adk-swisstopo
force-pushed
the
PB-1403-test
branch
3 times, most recently
from
May 29, 2026 11:18
421d316 to
f4b53c7
Compare
We test that the `Expires` header is set correctly in four different scenarios. The code extracting and comparing the header is duplicated four times. This change moves the code into a method which is called in each of the four cases with slightly different parametres. We also simplify the checks to let `assertAlmostEqual` and `assertIn` do the work themselves. This gives us better error messages too.
adk-swisstopo
force-pushed
the
PB-1403-test
branch
from
May 29, 2026 11:36
f4b53c7 to
4e7c66b
Compare
adk-swisstopo
changed the title
adk-swisstopo
marked this pull request as ready for review
May 29, 2026 11:39
ltshb
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We test that the
Expiresheader is set correctly in four different scenarios. The code extracting and comparing the header is duplicated four times.This change moves the code into a method which is called in each of the four cases with slightly different parametres. We also simplify the checks to let
assertAlmostEqualandassertIndo the work themselves. This gives us better error messages too.