Conversation
… nodes Fixed-length VLP (*2, *3) on denormalized schemas failed with "Missing table information for start node in cycle prevention" because extract_table_name returns None for virtual nodes that have no separate table. Fix: move extract_table_name calls inside the non-denormalized branch in both filter_builder.rs and plan_builder_utils.rs. For denormalized patterns, cycle prevention uses relationship columns (from_id/to_id) directly — no table name needed. Promotes 19 xfails: - 9 denormalized VLP tests (vlp_exact, vlp_range, vlp_path_var, shortest_path) - 10 polymorphic VLP tests (already generating correct SQL) Converts 3 invalid-property tests to skips (a.airport not valid). 12 coupled schema xfails remain (multi-relationship VLP untestable). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Code ReviewFix is clean and correctThe root cause is clear: Pre-existing asymmetry between parallel implementationsThe two parallel implementations have a subtle difference in the non-denormalized branch that predates this PR but is worth noting:
This divergence isn't introduced by this PR, but the two files are clearly meant to be parallel implementations. If one is correct for nested GraphRel, the other probably should be too. Test changes
Result: 151 passed, 38 skipped, 12 xfailed — solid improvementLGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_table_namereturns None for virtual nodesextract_table_namecalls inside the non-denormalized branch — denormalized patterns usefrom_id/to_idcolumns directly for cycle preventionfilter_builder.rsandplan_builder_utils.rs(parallel implementations)Impact
a.airportproperty)Updated test counts
Test plan
cargo fmtandcargo clippyclean🤖 Generated with Claude Code