Skip to content

docs: add mandatory branch workflow and PR requirements#14

Merged
github-actions[bot] merged 1 commit intomainfrom
docs/branch-workflow-requirements
Jan 13, 2026
Merged

docs: add mandatory branch workflow and PR requirements#14
github-actions[bot] merged 1 commit intomainfrom
docs/branch-workflow-requirements

Conversation

@genezhang
Copy link
Copy Markdown
Owner

BREAKING CHANGE: All development must now follow branch-based workflow

Changes:

  • Add Phase 0 (Create Branch) and Phase 6 (PR & Merge) to development process
  • Update from 5-phase to 6-phase development workflow
  • Rewrite git-workflow.md with branch-first approach
  • Emphasize bug fixes/improvements as primary work (late-stage development)
  • Add branch naming conventions with frequency indicators
  • Add pre-PR checklist and code review guidelines
  • Add quick reference for bug fix workflow
  • Establish absolute rules: never commit to main, always use PRs

Updated files:

  • DEVELOPMENT_PROCESS.md: Added Phase 0 and Phase 6, bug fix quick reference
  • docs/development/git-workflow.md: Complete rewrite with PR-first workflow

Note: copilot-instructions.md updated locally but not committed (internal use only)

Impact: All future development must create branches and submit PRs for review

BREAKING CHANGE: All development must now follow branch-based workflow

Changes:
- Add Phase 0 (Create Branch) and Phase 6 (PR & Merge) to development process
- Update from 5-phase to 6-phase development workflow
- Rewrite git-workflow.md with branch-first approach
- Emphasize bug fixes/improvements as primary work (late-stage development)
- Add branch naming conventions with frequency indicators
- Add pre-PR checklist and code review guidelines
- Add quick reference for bug fix workflow
- Establish absolute rules: never commit to main, always use PRs

Updated files:
- DEVELOPMENT_PROCESS.md: Added Phase 0 and Phase 6, bug fix quick reference
- docs/development/git-workflow.md: Complete rewrite with PR-first workflow

Note: copilot-instructions.md updated locally but not committed (internal use only)

Impact: All future development must create branches and submit PRs for review
@github-actions github-actions Bot merged commit 432c514 into main Jan 13, 2026
2 of 3 checks passed
@genezhang genezhang deleted the docs/branch-workflow-requirements branch January 13, 2026 03:44
genezhang added a commit that referenced this pull request Jan 20, 2026
Bug #11: Missing anyLast() wrapping for GROUP BY queries
- Added apply_anylast_wrapping_for_group_by() helper in plan_builder.rs
- Post-processes SELECT items to wrap non-ID, non-aggregated columns with anyLast()
- Fixes queries like: MATCH (a) OPTIONAL MATCH (a)-[r]->(b) RETURN a, count(b)
- Impact: TestOptionalMatch now 6/6 passing

Bug #14: Missing FROM clause with GROUP BY
- Added LogicalPlan::GroupBy case to find_graph_node() helper in from_builder.rs
- Allows FROM clause extraction to traverse through GroupBy logical plan nodes
- Fixes queries like: MATCH (n:User) RETURN n.name, count(*)
- Impact: TestGroupBy now 3/4 passing

Test Results:
- Before: 71/354 (20%)
- After: 221/354 (62.4%)
- 150 new tests passing!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant