docs: add mandatory branch workflow and PR requirements#14
Merged
github-actions[bot] merged 1 commit intomainfrom Jan 13, 2026
Merged
docs: add mandatory branch workflow and PR requirements#14github-actions[bot] merged 1 commit intomainfrom
github-actions[bot] merged 1 commit intomainfrom
Conversation
BREAKING CHANGE: All development must now follow branch-based workflow Changes: - Add Phase 0 (Create Branch) and Phase 6 (PR & Merge) to development process - Update from 5-phase to 6-phase development workflow - Rewrite git-workflow.md with branch-first approach - Emphasize bug fixes/improvements as primary work (late-stage development) - Add branch naming conventions with frequency indicators - Add pre-PR checklist and code review guidelines - Add quick reference for bug fix workflow - Establish absolute rules: never commit to main, always use PRs Updated files: - DEVELOPMENT_PROCESS.md: Added Phase 0 and Phase 6, bug fix quick reference - docs/development/git-workflow.md: Complete rewrite with PR-first workflow Note: copilot-instructions.md updated locally but not committed (internal use only) Impact: All future development must create branches and submit PRs for review
genezhang
added a commit
that referenced
this pull request
Jan 20, 2026
Bug #11: Missing anyLast() wrapping for GROUP BY queries - Added apply_anylast_wrapping_for_group_by() helper in plan_builder.rs - Post-processes SELECT items to wrap non-ID, non-aggregated columns with anyLast() - Fixes queries like: MATCH (a) OPTIONAL MATCH (a)-[r]->(b) RETURN a, count(b) - Impact: TestOptionalMatch now 6/6 passing Bug #14: Missing FROM clause with GROUP BY - Added LogicalPlan::GroupBy case to find_graph_node() helper in from_builder.rs - Allows FROM clause extraction to traverse through GroupBy logical plan nodes - Fixes queries like: MATCH (n:User) RETURN n.name, count(*) - Impact: TestGroupBy now 3/4 passing Test Results: - Before: 71/354 (20%) - After: 221/354 (62.4%) - 150 new tests passing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All development must now follow branch-based workflow
Changes:
Updated files:
Note: copilot-instructions.md updated locally but not committed (internal use only)
Impact: All future development must create branches and submit PRs for review