Skip to content

Improve efficiency of ORM lookup in dashboard#474

Open
code-review-doctor wants to merge 1 commit into
geex-arts:devfrom
code-review-doctor:django-doctor-fix-1612252107397.8674
Open

Improve efficiency of ORM lookup in dashboard#474
code-review-doctor wants to merge 1 commit into
geex-arts:devfrom
code-review-doctor:django-doctor-fix-1612252107397.8674

Conversation

@code-review-doctor

@code-review-doctor code-review-doctor commented Feb 2, 2021

Copy link
Copy Markdown

I found this issue automatically using https://django.doctor/geex-arts/django-jet

@code-review-doctor code-review-doctor changed the title Fix some django anti-patterns Improve efficiency of ORM lookup in dashboard Feb 2, 2021
).all()

if len(module_models) == 0:
if not module_models.exists():

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls

coveralls commented Feb 2, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 52.381% when pulling 797da5b on django-doctor:django-doctor-fix-1612252107397.8674 into 06ab643 on geex-arts:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants