feat(ethexe): add Router.protocolVersion to contracts & client#5542
Open
StackOverflowExcept1on wants to merge 3 commits into
Open
feat(ethexe): add Router.protocolVersion to contracts & client#5542StackOverflowExcept1on wants to merge 3 commits into
Router.protocolVersion to contracts & client#5542StackOverflowExcept1on wants to merge 3 commits into
Conversation
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
playX18
approved these changes
Jun 2, 2026
breathx
requested changes
Jun 2, 2026
Member
breathx
left a comment
There was a problem hiding this comment.
Remove hard pin to specific version and allow any compatible + bump only version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5440
Summary
This PR adds ability to update protocol version on
Routerand creates corresponding event that makes graceful join on nodes if version does not match, and also check of protocol version before creation has been added to client constructor.How to test
cargo build --package ethexe-cli ./target/debug/ethexe run --dev --validators-malachite-pub-keys file.json cast send \ 0xCf7Ed3AccA5a467e9e704C703E8D87F634fB0Fc9 \ "function bumpProtocolVersion(uint256 newProtocolVersion) external" \ --private-key 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80Checklist
type(scope): description)