update bcryptjs#2368
Merged
GCHQDeveloper581 merged 2 commits intogchq:masterfrom May 9, 2026
Merged
Conversation
GCHQDeveloper581
approved these changes
May 9, 2026
Contributor
GCHQDeveloper581
left a comment
GCHQDeveloper581
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates bcryptjs to v3.0.3.
Updates usage of
compareto match new typescript definitions expectingundefinednotnull.Updates tests as bcryptjs now generates
2bhashes rather than2a. It could be argued that this is a breaking change, but it is still outputting a valid Bcrypt hash, so I think it is OK.Existing Issue
#2214
AI disclosure
gpt-5.5
Test Coverage
Yes