Upgrade Extract Audio Metadata handling - #2356
Open
d0s1nt wants to merge 9 commits into
Open
Conversation
New operation that extracts metadata from 10 audio formats: MP3 (ID3v2/ID3v1), WAV/BWF/BW64 (RIFF INFO/bext/iXML/axml), FLAC (Vorbis Comment), OGG Vorbis, Opus, AAC (ADTS), AC3, WMA (ASF), MP4/M4A, and AIFF. Outputs normalized JSON, rendered as an HTML table via present(). Includes 28 tests covering all formats with deep validation of container detection, MIME types, common tags, format-specific sections (ID3v2 frames, Vorbis comments, ADTS fields, AC3 BSI, ASF Content Description), and technical metadata values.
Split the monolithic ExtractAudioMetadata.mjs (1,550 lines) into four focused files totalling 990 lines: - src/core/lib/AudioBytes.mjs: byte-reading and text-decoding utilities - src/core/lib/AudioMetaSchema.mjs: report skeleton and container detection - src/core/lib/AudioParsers.mjs: all 9 format parsers and internal helpers - src/core/operations/ExtractAudioMetadata.mjs: operation class only Also replaces infoURL with a Wikipedia link per review feedback. No functional changes — all 1,805 tests pass, ESLint clean.
4 tasks
Contributor
|
Hi, It looks like you've continued development on your existing branch rather than re-branching off master. The result is that we've got a lot of the old commits repeated (because we squash the commits when merging) and this is causing merge conflicts. Could you start again from the master branch (making sure that your fork/local master is fully synced up to ours). You may be able to cherry pick the latest commit onto your new branch, or alternatively copy the updated files from the old into the new branch and re-commit. (Apologies if I am over-explaining git techniques with which you are readily familiar) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the merged Extract Audio Metadata operation from #2170 with richer C2PA/JUMBF/CBOR extraction, cleaner CyberChef table output, and expanded tests.\n\nVerified: 42/42 operation tests pass; production build passes.