feat: add +/- notation option to Diff operation#2343
Open
Sushanth012 wants to merge 1 commit intogchq:masterfrom
Open
feat: add +/- notation option to Diff operation#2343Sushanth012 wants to merge 1 commit intogchq:masterfrom
Sushanth012 wants to merge 1 commit intogchq:masterfrom
Conversation
C85297
requested changes
Apr 28, 2026
Member
C85297
left a comment
There was a problem hiding this comment.
Hi @Sushanth012 , thank you for the pull request!
I am worried the changes might not have the effect you desire in certain conditions - such as if diffChars is selected. Your code assumes that the returned value from jsdiff is split by lines, but I don't believe this to always be the case.
Could you confirm if you've tested this locally, and ideally provide screenshots so we can review the UI behaviour?
And could you also add a test case (unfortunately there isn't an existing one for Diff, but you could copy one of the tests in tests/operations/tests and implement a test just for this +/- functionality)
Member
|
@Sushanth012 jsdiff does seem to support a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2312
Added a "Show +/- notation" boolean option to the Diff operation (default: false).
When enabled:
Output is compatible with standard unified diff format, allowing export to tools like Slack's diff snippet viewer. Existing highlighting behavior is unchanged when the option is off.